How to advise my friend...

So I was talking to my friend at our lunch about 2 days ago and we were talking about girls that we liked and he revealed that he has been liking this girl, whom he's been really good friends with, for about 3 years now and its the only girl he's liked. He's never had the nerve to tell her how he really feels though he's beginning to hint at it. And now that we're seniors in high school and this is it, he wants to tell her how he really feels. I told him he should man up and do it we've only got a few months left. Is this alright advice for the situation? or are there any other reccomendations?

Of course this was the right thing to say. If not now, when?

yeah...tell him to grow a pair...

Does he want to live with regret? If not, then your advice was adequate.

I hate tryin to convince my shy friends to talk to the girls they like... LoL I don't mind doin it but they just are so hard headed they never wanna listen... or they listen and be like "yeah you're right.. yeah I should.. yeah okay I'm gonna do that" but then they sissy out of doin anything.

Tell him - the world isn't going to end if you talk to her. It's much better to have TRIED and failed, knowing you did your part to find out if you guys are a match, and can move on with your life knowing she just wasn't the one for you, than to NOT try and live with regret for however long your mind decides to hold onto the image of her.